fix(ssh): add ip address to web session #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybarreto
force-pushed
the
fix/web_session_ip
branch
from
ff49645
to
aeedb68
Compare
henrybarreto
force-pushed
the
fix/web_session_ip
branch
5 times, most recently
from
65bb797
to
45d65e6
Compare
When logging from the web interface, we could not get the client IP as the connection was coming, officially, from the own server. In the past, we have used environment variables to set this data, but after the last SSH refactor, we lost this capability. To solve the problem, we have used a generated UUID on the connection creation to capture the IP of web session, saving it on cache, and retrieving it on the SSH server it detected web session.
henrybarreto
force-pushed
the
fix/web_session_ip
branch
from
45d65e6
to
63160ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.