release back to pool on photon discard event

[res6idue]

This PR fixes the issue that the memory gets used up, resulting in a kill during some simulations

---

This change is 

[Naphann]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @res6idue and @zigen)

---

quisp/modules/PhysicalConnection/BSA/BellStateAnalyzer.cc line 178 at r1 (raw file):

}

void BellStateAnalyzer::measureSuccessfully(PhotonRecord &p, PhotonRecord &q, bool is_psi_plus) {

If discard photon function doesn't return photonic qubits to pool properly. What about this one? Have you checked this case?

[res6idue]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Naphann and @zigen)

---

quisp/modules/PhysicalConnection/BSA/BellStateAnalyzer.cc line 178 at r1 (raw file):

Previously, Naphann (Naphan Benchasattabuse) wrote…

If discard photon function doesn't return photonic qubits to pool properly. What about this one? Have you checked this case?

I think for the case when we hit this function, we still arrive at discard photons
Well I think that when we fail in the indistinguishable window, we also need to discard those photons, so I will fix it.

[res6idue]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Chibikuri, @Naphann, and @zigen)

---

quisp/modules/PhysicalConnection/BSA/BellStateAnalyzer.cc line 178 at r1 (raw file):

Previously, res6idue (soon) wrote…

I think for the case when we hit this function, we still arrive at discard photons
Well I think that when we fail in the indistinguishable window, we also need to discard those photons, so I will fix it.

Fixed.

[Naphann]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Chibikuri, @res6idue, and @zigen)

---

quisp/modules/PhysicalConnection/BSA/BellStateAnalyzer.cc line 178 at r1 (raw file):

Previously, res6idue (soon) wrote…

Fixed.

See my other comment.

---

quisp/modules/PhysicalConnection/BSA/BellStateAnalyzer.cc line 102 at r2 (raw file):

    auto q = second_port_records[i];

    if (fabs(p.arrival_time - q.arrival_time) < indistinguishability_window) {

What about this case? Do they get returned to the pool properly somewhere?

[res6idue]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Chibikuri, @Naphann, and @zigen)

---

quisp/modules/PhysicalConnection/BSA/BellStateAnalyzer.cc line 102 at r2 (raw file):

Previously, Naphann (Naphan Benchasattabuse) wrote…

What about this case? Do they get returned to the pool properly somewhere?

sorry, I forgot to add the discard photon function for the successful case.

[res6idue]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @Chibikuri, @Naphann, and @zigen)

---

quisp/modules/PhysicalConnection/BSA/BellStateAnalyzer.cc line 102 at r2 (raw file):

Previously, res6idue (soon) wrote…

sorry, I forgot to add the discard photon function for the successful case.

Added.

[Naphann]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Chibikuri and @zigen)

[zigen]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Chibikuri)

[Naphann]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Chibikuri)