Merge pull request #804 from serlo/improve-course-page-alias

chore(alias): small changes to course page alias code
serlo · Jun 19, 2024 · 07df0b4 · 07df0b4
2 parents 5843d1d + 205c400
commit 07df0b4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/__tests__/__utils__/services/database.ts b/__tests__/__utils__/services/database.ts
@@ -13,7 +13,7 @@ export function getUuid(instance: Instance, path: string) {
   const regexes = [
     new RegExp('^/(?<id>\\d+)$'),
     new RegExp(
-      '(?<subject>[^/]+/)?(?<id>\\d+)(?<coursePageId>/[a-z0-9-]+)?/(?<title>[^/]*)$',
+      '(?<subject>[^/]+/)?(?<id>\\d+)(?<coursePageId>/[0-9a-f]+)?/(?<title>[^/]*)$',
     ),
   ]
 

diff --git a/src/current-alias-redirects.ts b/src/current-alias-redirects.ts
@@ -158,8 +158,12 @@ async function getPathInfo(
         } else {
           const subject = uuid.alias.split('/').at(1) ?? 'serlo'
           const slugTitle = toSlug(coursePage.title)
-
-          currentPath = `/${subject}/${uuid.id}/${coursePage.id.slice(0, 8)}/${slugTitle}`
+          const shortPageId = coursePage.id.split('-').at(0)
+          if (!shortPageId) {
+            currentPath = uuid.alias
+          } else {
+            currentPath = `/${subject}/${uuid.id}/${shortPageId}/${slugTitle}`
+          }
         }
       }
     } catch (e) {