Implement VOICE_CHANNEL_STATUS_UPDATE #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
arqunis
added
enhancement
jamesbt365
force-pushed
the
voice-channel-status
branch
from
62fb38e
to
9a6a135
Compare
github-actions
bot
added
builder
|
I have gone ahead and pushed a new function to EditChannel to change the status, not sure if the comments I've put on it are 100% correct because I am yet to fully test. Also included the permission to do so, not sure if I need to change anything else alongside that. I am pulling everything off discord/discord-api-docs/pull/6398 but its not merged yet so things might change or I might be wrong in some places. |
|
If anything would be better off split into a different pull request I'll do so, just ask. |
jamesbt365
force-pushed
the
voice-channel-status
branch
from
c3f12f1
to
4339118
Compare
arqunis
reviewed
Oct 18, 2023
AngelOnFira
approved these changes
Oct 19, 2023
arqunis
approved these changes
Oct 20, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will cleanup the code, format this right later and document whatever I can later. I thought thought it would be in a decent enough state to be opened as a draft.
Not sure if you even want this yet given that the documentation for this isn't even merged yet and is just a draft pull request on discord/discord-api-docs
I had no idea what I was doing with the CacheUpdate, so the code is probably not even close to what it could be.