Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tie alias creation to premium subscriptions #699

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

brassy-endomorph
Copy link
Collaborator

@brassy-endomorph brassy-endomorph commented Oct 17, 2024

fixes #645

  • split utils.py into smaller modules to get rid of circular imports
  • add ALIAS_MODE config
  • gate number of aliases on ALIAS_MODE and/or premium status

@glenn-sorrentino
Copy link
Member

Subscribed users get 100 aliases. Single-tenant is unlimited. Free is none.

@glenn-sorrentino
Copy link
Member

Will leave comments while testing:

First - In the screenshot, I have not subscribed and have no aliases. the To: string in the user's inbox is only applicable if they have at least one alias.

Screenshot 2024-10-17 at 9 30 01 AM

@glenn-sorrentino
Copy link
Member

Other than the comment above, the functionality on the front-end works well!

@glenn-sorrentino
Copy link
Member

Noticing during the cancel
Screenshot 2024-10-17 at 9 39 30 AM
subscription flow that the page isn't redirecting back to the premium page...

@brassy-endomorph
Copy link
Collaborator Author

brassy-endomorph commented Oct 17, 2024

@glenn-sorrentino
Copy link
Member

glenn-sorrentino commented Oct 17, 2024

Also when I click "Cancel Now" I'm directed to the disable auto-renew page, but that's a different feature from canceling...

cancel-sub

@brassy-endomorph
Copy link
Collaborator Author

Those sound like bugs for other tickets because they're not directly related to this PR and shoulnd't be addressed here. That will just make this ticket massive and more difficult to get merged. I can do that in a followup too, but it's not really relevant to the changeset I'm proposing.

@glenn-sorrentino
Copy link
Member

Those sound like bugs for other tickets because they're not directly related to this PR and shoulnd't be addressed here. That will just make this ticket massive and more difficult to get merged. I can do that in a followup too, but it's not really relevant to the changeset I'm proposing.

By "those", which of the above do you mean?

@brassy-endomorph
Copy link
Collaborator Author

#699 (comment)

and

#699 (comment)

Canceling / disabling autorenew should be separate tickets

@brassy-endomorph brassy-endomorph force-pushed the make-aliases-dependent-on-subscription branch from 4479c6e to dc9a5f3 Compare October 17, 2024 19:57
@brassy-endomorph brassy-endomorph force-pushed the make-aliases-dependent-on-subscription branch from dc9a5f3 to b896a82 Compare October 17, 2024 20:50
@brassy-endomorph brassy-endomorph marked this pull request as ready for review October 17, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate alias feature with paid tiers
2 participants