-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move config parsing to own module #686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brassy-endomorph
force-pushed
the
config-parsing
branch
3 times, most recently
from
October 10, 2024 20:10
928b291
to
4185c7e
Compare
Loggin in causes this:
|
I didn't actually test it yet. Just got it to pass CI, and this check is whether this method looks sensible. But yes, noted. |
brassy-endomorph
force-pushed
the
config-parsing
branch
from
October 11, 2024 07:42
4185c7e
to
353bed3
Compare
brassy-endomorph
force-pushed
the
config-parsing
branch
from
October 11, 2024 08:23
353bed3
to
f367ca4
Compare
brassy-endomorph
force-pushed
the
config-parsing
branch
from
October 11, 2024 08:30
d4b8551
to
770f6dd
Compare
glenn-sorrentino
approved these changes
Oct 11, 2024
scidsg-dev
added a commit
that referenced
this pull request
Oct 16, 2024
Revert "Merge pull request #686 from scidsg/config-parsing"
brassy-endomorph
added a commit
that referenced
this pull request
Oct 16, 2024
This reverts commit 7c74f17.
brassy-endomorph
added a commit
that referenced
this pull request
Oct 16, 2024
Revert "Revert "Merge pull request #686 from scidsg/config-parsing""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #637
This is a minimal change to organize the config parsing (somewhat) according to some logic that seemed reasonable to me (for now). There are some slight change in the parsing logic so we don't set empty/
None
values in a bunch of places since this make some logic a little cleaner so we can do tests likeif "KEY" in app.config
which is different thanif app.config.get("KEY")
.config.py
HL_CFG_
HL_CFG_JSON_
as JSON