Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use postgres everywhere #572

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Use postgres everywhere #572

merged 3 commits into from
Sep 11, 2024

Conversation

brassy-endomorph
Copy link
Collaborator

  • Adds a script to start a standalone docker container for testing
  • Configures tests to use postgres including fixtures for isolating database per test function
  • Updates github actions to test against postgres

Fixes #557
Fixes #569
Partially addresses #546

@brassy-endomorph brassy-endomorph force-pushed the use-postgres-everywhere branch 2 times, most recently from fee5cca to d0ab5af Compare September 10, 2024 21:11
glenn-sorrentino
glenn-sorrentino approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@glenn-sorrentino glenn-sorrentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Ran app locally
✅ Created new account
✅ Added settings
✅ Tested with new dev instructions

@brassy-endomorph brassy-endomorph merged commit bf3124b into main Sep 11, 2024
7 checks passed
@brassy-endomorph brassy-endomorph deleted the use-postgres-everywhere branch September 11, 2024 06:22
@micahflee micahflee mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glenn-sorrentino glenn-sorrentino glenn-sorrentino approved these changes

@micahflee micahflee Awaiting requested review from micahflee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Foreign keys are not respected on row deletion Test cases should use Postgres and not sqlite:///:memory:
2 participants
@brassy-endomorph @glenn-sorrentino