Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/SK-1078 | Added virtual environment details in quickstart #715

Merged
merged 10 commits into from
Oct 11, 2024

Conversation

Hovstadius
Copy link
Contributor

Added a step (1.5) in the quickstart guide of how to set up and activate a virtual environment.

@Hovstadius Hovstadius added feature New feature or request docs labels Oct 2, 2024
@github-actions github-actions bot added the minor label Oct 2, 2024
Copy link
Member

@Wrede Wrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment, request review again after answer.

:caption: Windows (Powershell)

python -m venv fedn_env
.\fedn_env\Scripts\Activate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested this? I was not able to do this is my powershell because of admin rights, instead I used CMD.exe and then there is a .bat file to activate instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do further testing later today on my windows machine.
Wouldn't switching to CMD be a bad decision since we later use PowerShell to start the clients?
A workaround could also be starting PowerShell in admin mode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works on my windows machine, I've added a line to bypass the admin permissions if that error shows up

@Hovstadius
Copy link
Contributor Author

I also added copy code buttons for the code boxes to make it easier to work with the guides.

@Hovstadius Hovstadius requested a review from Wrede October 2, 2024 14:32
Copy link
Member

@Wrede Wrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want atleast 2 windows machine to have tested it. I can test on mine, but probably next week.

@Hovstadius Hovstadius requested a review from Wrede October 9, 2024 09:20
Copy link
Member

@Wrede Wrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes orally

@Hovstadius
Copy link
Contributor Author

Added instructions for CMD.exe and also added a link to Python venv documentation if further information is needed.

@Hovstadius Hovstadius requested a review from Wrede October 10, 2024 09:20
@Wrede Wrede changed the title Feature/SK-1078 | Added virtual environment details in quickstart Docs/SK-1078 | Added virtual environment details in quickstart Oct 11, 2024
@Wrede Wrede removed the feature New feature or request label Oct 11, 2024
@Wrede Wrede merged commit a7ef5b2 into master Oct 11, 2024
10 checks passed
@Wrede Wrede deleted the feature/SK-1078 branch October 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants