Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/SK-895 | Use the system's default cert store #711

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Feature/SK-895 | Use the system's default cert store #711

merged 1 commit into from
Sep 27, 2024

Conversation

stefanhellander
Copy link
Collaborator

Description

Fixes security warning, but also:

  • We've been downloading the cert to create the secure GRPC connection. This is not necessary, instead we can let gRPC use the system's default cert store instead. There is already an environment variable that can be set if you have your own CA bundle that you want to use.

@github-actions github-actions bot added minor feature New feature or request labels Sep 26, 2024
@Wrede Wrede changed the title feature/SK-895 | Use the system's default cert store Feature/SK-895 | Use the system's default cert store Sep 27, 2024
@Wrede Wrede merged commit 9e675b2 into master Sep 27, 2024
19 of 20 checks passed
@Wrede Wrede deleted the feature/SK-895 branch September 27, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wrede Wrede Wrede approved these changes

Assignees
No one assigned
Labels
feature New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanhellander @Wrede