Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cypress and other deps #280

Merged
merged 4 commits into from
Feb 23, 2024
Merged

chore: bump cypress and other deps #280

merged 4 commits into from
Feb 23, 2024

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Feb 22, 2024

Description

  • Bump cypress to 13.6.5 and other deps.
  • Removed @babel/plugin-proposal-class-properties - deprecated. There is now @babel/plugin-transform-class-properties, but then I started thinking, we're using tsc to compile so we don't need any babel plugins...right? Or am I misunderstanding a use case?

DEVX-2729

@mhan83 mhan83 requested a review from a team as a code owner February 22, 2024 18:31
@alexplischke
Copy link
Contributor

we're using tsc to compile so we don't need any babel plugins...right? Or am I misunderstanding a use case?

I see that babel-jest is also a dependency. So used when calling typescript from js/ts based tests. The existing tests are all e2e tests with Cypress, and are therefore executed by Cypress itself, so this dependency is not actually utilized from what I can tell. It's possible that there were some unit/integration tests in the past that were run directly by jest before (now gone) 🤷

@mhan83
Copy link
Contributor Author

mhan83 commented Feb 23, 2024

we're using tsc to compile so we don't need any babel plugins...right? Or am I misunderstanding a use case?

I see that babel-jest is also a dependency. So used when calling typescript from js/ts based tests. The existing tests are all e2e tests with Cypress, and are therefore executed by Cypress itself, so this dependency is not actually utilized from what I can tell. It's possible that there were some unit/integration tests in the past that were run directly by jest before (now gone) 🤷

Gotcha. OK, so I'll proceed and remove that dependency. I'll clean up the babel stuff in a separate PR.

@mhan83 mhan83 merged commit 67c16d6 into main Feb 23, 2024
32 checks passed
@mhan83 mhan83 deleted the feb-bump branch February 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants