-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace mocha junit reports with our own #275
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
266bd2e
feat: replace mocha junit reports with our own
alexplischke 9b8fe31
refactor: cleanup
alexplischke 7b4f973
refactor: dry
alexplischke 7fbb2bf
docs: engrish
alexplischke 70f64f1
fix: don't create reports when there's nothing to create from
alexplischke 4d43d51
fix: stop passing around wrong types
alexplischke fd8cb03
deps: bump @saucelabs/cypress-plugin@3.1.3
alexplischke a5857e8
allow report generation on failure
alexplischke f7732bb
refactor: remove obsolete reporter
alexplischke 23277f9
refactor: remove unused exports
alexplischke cc51686
refactor: remove unnecessary wrapper
alexplischke 8c82e41
build: allow jest to pass without tests
alexplischke c75bec5
deps: remove obsolete mocha-junit-reporter
alexplischke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,33 @@ | ||
#!/usr/bin/env node | ||
|
||
const { cypressRecorder } = require('../lib/cypress-recorder'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
const stream = require('stream'); | ||
const childProcess = require('child_process'); | ||
|
||
(async () => await cypressRecorder())(); | ||
const fd = fs.openSync( | ||
path.join(process.cwd(), 'console.log'), | ||
'w+', | ||
0o644 | ||
); | ||
const ws = new stream.Writable({ | ||
write (data, encoding, cb) { | ||
fs.write(fd, data, undefined, encoding, cb); | ||
} | ||
}); | ||
|
||
const [nodeBin] = process.argv; | ||
const child = childProcess.spawn(nodeBin, [ | ||
path.join(__dirname, 'lib', 'cypress-runner.js'), | ||
...process.argv.slice(2) | ||
]); | ||
|
||
child.stdout.pipe(process.stdout); | ||
child.stderr.pipe(process.stderr); | ||
child.stdout.pipe(ws); | ||
child.stderr.pipe(ws); | ||
|
||
child.on('exit', (exitCode) => { | ||
fs.closeSync(fd); | ||
process.exit(exitCode); | ||
}); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
--passWithNoTests
was added because with the removal of the custom reporter spec, there are no more unit tests remaining in the project. I could remove the CI step that runs the unit tests, if folks prefer that to this change.