Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): handle SAS9 execution error gracefully #1065

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

krishna-acondy
Copy link
Contributor

@krishna-acondy krishna-acondy commented Dec 12, 2021

Issue

#1063

Intent

Handle job execution errors during SAS9 deployments.

Implementation

Catch JobExecutionErrors and save the log output to the usual log file path.
sasjs/adapter#601 also fixes the adapter logic to return the correct error code so the 'missing SASjs runner' message is avoided.

A deploy that fails with stored process errors will now output this:
image

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

@krishna-acondy krishna-acondy marked this pull request as draft December 12, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants