Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KDE neon to list of Ubuntu derivates (again) #2016

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

digitalkram
Copy link
Contributor

What does this PR do?

Added KDE neon to list of Ubuntu derivates (again)

What issues does this PR fix or reference?

Previous Behavior

When run on KDE neon bootstrap-salt.sh terminated with ERROR: No dependencies installation function found. Exiting....

New Behavior

When run on KDE neon bootstrap-salt.sh now doesn't terminate with the above error but works as intended.

@rolszewo
Copy link

please merge this little, but helpful PR.
i have the same problem.

@dmurphy18
Copy link
Contributor

@digitalkram Sorry about forgetting to add neon to the UBUNTU_DERIVATIVES. Just checking but are the neon_xx_ubuntu_base correct ?, also there are failing tests, look unrelated but all tests should be passing before it can be merged.

@dmurphy18
Copy link
Contributor

But those failing tests appear unrelated to your changes, see #2003
Looking into why 3007.0+xxxxx is getting used rather than current 3007.1+xxxxx from Salt git master, etc.

@digitalkram
Copy link
Contributor Author

Afaict neon_xx_ubuntu_base are correct

@dmurphy18 dmurphy18 merged commit 3c48309 into saltstack:develop Sep 17, 2024
182 of 187 checks passed
@dmurphy18
Copy link
Contributor

@digitalkram FYI, releases bootstrap with your fix, 2024-090-24 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants