contrib: use jq instead of sed #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryantm if this doesn't quite fit feel free to close, no hard feelings. |
|
Actually let me make sure rekeying works. Should probably also add a test for rekeying to CI. |
|
Great if you can add a test. Since this is just the CLI I care a lot less about the closure size! |
|
I have a WIP PR to expand the current integration test to also include some CLI features (starting with Will rebase this on that -- assuming it's deemed appropriate to merge -- which will help ensure the CLI (and hence this PR) are working as intended. |
|
I just rebased this on main so it would run the rekeying test. |
ryantm
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147