Introduce generic hypercall ioctl #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NunoDasNeves
requested review from
russell-islam,
liuw and
jinankjain
as code owners
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
from
4ec6798
to
5b8f112
Compare
|
Please update the subject line of the PR with more meaningful one. |
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
2 times, most recently
from
cd9e047
to
ee0cfa7
Compare
NunoDasNeves
changed the title
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
from
ee0cfa7
to
af04ea1
Compare
|
Overall looks good functionally. Those macros are a bit hard to understand, If you could provide some example with data it would be good for the reviewers. |
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
from
af04ea1
to
fc82497
Compare
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
3 times, most recently
from
30759b3
to
1719d70
Compare
4 tasks
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
5 times, most recently
from
ee8b081
to
dc67278
Compare
NunoDasNeves
changed the title
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
from
dc67278
to
77d4f14
Compare
NunoDasNeves
changed the title
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
3 times, most recently
from
04731d9
to
2c3696d
Compare
NunoDasNeves
changed the title
Don't use "EIO" as a special code for determining whether there is a hypercall error. Simply check if there is a hypercall error code. Signed-off-by: Nuno Das Neves <nudasnev@microsoft.com>
Signed-off-by: Nuno Das Neves <nudasnev@microsoft.com>
Signed-off-by: Nuno Das Neves <nudasnev@microsoft.com>
Signed-off-by: Nuno Das Neves <nudasnev@microsoft.com>
This will be used with the generic hvcall ioctl for vcpus. Signed-off-by: Nuno Das Neves <nudasnev@microsoft.com>
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
from
2c3696d
to
9ead785
Compare
|
@jinankjain @russell-islam @liuw This PR is reworked and ready for another round of review. |
russell-islam
approved these changes
Apr 23, 2024
While leaving existing implementations untouched. Add: - VmFd::hvcall_set_partition_property - VcpuFd::hvcall_translate_gva - VcpuFd::hvcall_get_cpuid_values - VcpuFd::hvcall_get_reg - VcpuFd::hvcall_set_reg Add tests for the above. Signed-off-by: Nuno Das Neves <nudasnev@microsoft.com>
NunoDasNeves
force-pushed
the
nudasnev/generic-hypercall-ioctl
branch
from
9ead785
to
c03ec9c
Compare
liuw
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This PR introduces the generic hypercall IOCTL - MSHV_ROOT_HVCALL.
It can be used on both the partition and vp fds.
This IOCTL reduces the number of IOCTLs needed in the kernel interface, reducing maintenance and making the kernel code more upstreamable.
This PR introduces the IOCTL and implements some use-cases for it, but it doesn't replace the default implementations so it won't affect downstream.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.