Introduce RISC-V architecture support #190
Conversation
TimePrinciple
requested review from
sameo,
rbradford,
roypat,
andreitraistaru and
ShadowCurse
as code owners
TimePrinciple
changed the title
TimePrinciple
force-pushed
the
introduce-riscv-architecture
branch
from
b14019c
to
05c0d12
Compare
TimePrinciple
force-pushed
the
introduce-riscv-architecture
branch
4 times, most recently
from
3d64381
to
8a465c5
Compare
|
@roypat @rbradford @ShadowCurse PTAL when convenient :) |
Initial porting to support loading Linux PE Image on RISC-V platform. Signed-off-by: Tan En De <ende.tan@starfivetech.com>
Refactor RISC-V loader to work with PE image. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
Introduce configurator module of riscv64. Implement `Configurator` for riscv64 platform, add according unit-tests. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
As `rustfmt` suggested, `config` is deprecated, moving to `config.toml`. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
Add `.platform` file to enable x86_64, aarch64, riscv64 CI. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
As clippy command in our CI mandates: `cargo clippy --workspace --bins --examples --benches --all-features --all-targets -- -D warnings -D clippy::undocumented_unsafe_blocks`, add benchmarck test to appease clippy. Signed-off-by: Ruoqing He <heruoqing@iscas.ac.cn>
TimePrinciple
force-pushed
the
introduce-riscv-architecture
branch
from
8a465c5
to
e8a636f
Compare
There was a problem hiding this comment.
Instead of duplicating this entire benchmark, let's just rename the aarch64.rs file to something more appropriate (fdt.rs, maybe), and simply have it cfg'd with `any(target_arch = "aarch64", target_arch = "riscv64")
There was a problem hiding this comment.
This file is also a 1:1 copy of the one in the aarch64 module. Let's figure out a way to reuse these somehow
| /// | ||
| /// # Returns | ||
| /// * KernelLoaderResult | ||
| fn load<F, M: GuestMemory>( |
There was a problem hiding this comment.
This is also very similar to the existing aarch64 code. Can we reuse part of it somehow?
Yes, I noticed that, I just copied these files incase there is something to be diverged in the future I can try to merge the common part as possible, but what should we name that, like |
Maybe move the fdt code to a higher level and then |
Summary of the PR
Introduce RISC-V architecture to
loader, bringing #163 forward.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.