fix: missing_debug_implementations
#154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
requested review from
alxiord,
sameo,
rbradford,
roypat and
andreitraistaru
as code owners
JonathanWoollett-Light
force-pushed
the
missing_debug_implementations
branch
2 times, most recently
from
77725a9
to
8edbad1
Compare
alxiord
previously approved these changes
Jun 5, 2023
roypat
previously approved these changes
Jun 19, 2023
JonathanWoollett-Light
dismissed stale reviews from roypat and alxiord
via
cd8af3c
JonathanWoollett-Light
force-pushed
the
missing_debug_implementations
branch
from
3c3c599
to
cd8af3c
Compare
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
missing_debug_implementations
branch
from
cd8af3c
to
5c35bac
Compare
|
@JonathanWoollett-Light do you still want to get this merged? If yes, can you fix the conflicts? Otherwise please close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Sets
missing_debug_implementationsto deny and adds missingstd::fmt::Debugimplementations.When tracing/logging/debugging a program it is common to debug print inputs and outputs of function, to do this generally dependencies need to offer
std::fmt::Debugimplementations.I won't repeat what is written under
missing_debug_implementationswhich gives some more explanation.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.