-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(login): api key #840
feat(login): api key #840
Conversation
…taquality into feat/login/api-key
@@ -30,7 +30,7 @@ | |||
dataquality.get_insights() | |||
""" | |||
|
|||
__version__ = "1.6.1" | |||
__version__ = "2.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also update this in pyproject.toml
?
tests/conftest.py
Outdated
if os.environ.get("PYTEST_XDIST_WORKER_COUNT"): | ||
pid = os.getpid() | ||
os.environ["SCIKIT_LEARN_DATA"] = f"~/scikit_learn_data_{pid}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a fixture?
tests/core/test_auth.py
Outdated
@mock.patch("requests.post", side_effect=mocked_failed_login_requests) | ||
def test_bad_login(mock_post: MagicMock, set_test_config: Callable) -> None: | ||
set_test_config(token=None) | ||
os.environ[GALILEO_AUTH_METHOD] = "email" | ||
del os.environ["GALILEO_API_KEY"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, ugly... Can we do this with monkey patch, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🔑 🚪
Shortcut:
https://app.shortcut.com/galileo/story/13305/dq-login-via-api-key
Description:
Allow for user login via api key
Tests:
Building off of https://github.com/rungalileo/dataquality/pull/835/files