chore: remove version check warning

rungalileo · Mar 18, 2024 · c0a1633 · c0a1633
1 parent acddffd
commit c0a1633
Show file tree

Hide file tree

Showing 16 changed files with 2 additions and 72 deletions.
diff --git a/dataquality/__init__.py b/dataquality/__init__.py
@@ -30,7 +30,7 @@
         dataquality.get_insights()
 """
 
-__version__ = "2.0.1"
+__version__ = "2.0.2"
 
 import sys
 from typing import Any, List, Optional

diff --git a/dataquality/core/init.py b/dataquality/core/init.py
@@ -29,7 +29,6 @@
 from dataquality.utils.dq_logger import DQ_LOG_FILE_HOME
 from dataquality.utils.helpers import check_noop
 from dataquality.utils.name import validate_name
-from dataquality.utils.version import version_check
 
 api_client = ApiClient()
 
@@ -183,7 +182,6 @@ def init(
     if not api_client.valid_current_user():
         login()
     _check_dq_version()
-    version_check()
     _init = InitManager()
     task_type = BaseGalileoLogger.validate_task(task_type)
     config.task_type = task_type

diff --git a/pyproject.toml b/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
 name = "dataquality"
-version = "2.0.1"
+version = "2.0.2"
 description = ""
 authors = ["Galileo Technologies, Inc. <team@rungalileo.io>"]
 readme = "README.md"

diff --git a/tests/core/test_init.py b/tests/core/test_init.py
@@ -37,15 +37,13 @@
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name", return_value={})
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 @patch("dataquality.core.init.create_run_name", return_value="foo")
 def test_init(
     mock_create_run_name: MagicMock,
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -71,15 +69,13 @@ def test_init(
 
 @patch.object(ApiClient, "get_project_by_name")
 @patch.object(ApiClient, "get_project_run_by_name")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 @patch("dataquality.core.init.create_run_name", return_value="foo")
 def test_init_reset_logger_config(
     mock_create_run_name: MagicMock,
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_get_project_by_name: MagicMock,
     set_test_config: Callable,
@@ -100,15 +96,13 @@ def test_init_reset_logger_config(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name", return_value={})
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 @patch("dataquality.core.init.create_run_name", return_value="foo")
 def test_init_new_private_project(
     mock_create_run_name: MagicMock,
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -136,15 +130,13 @@ def test_init_new_private_project(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name", return_value={})
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 @patch("dataquality.core.init.create_run_name", return_value="foo")
 def test_init_existing_project(
     mock_create_run_name: MagicMock,
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -173,15 +165,13 @@ def test_init_existing_project(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name", return_value={})
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 @patch("dataquality.core.init.create_run_name", return_value="foo")
 def test_init_new_project(
     mock_create_run_name: MagicMock,
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -211,13 +201,11 @@ def test_init_new_project(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name", return_value={})
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 def test_init_existing_project_new_run(
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -250,13 +238,11 @@ def test_init_existing_project_new_run(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name")
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 def test_init_existing_project_existing_run(
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -289,13 +275,11 @@ def test_init_existing_project_existing_run(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name", return_value={})
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 def test_init_new_project_run(
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -326,13 +310,11 @@ def test_init_new_project_run(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name")
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 def test_init_only_run(
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -355,15 +337,13 @@ def test_init_only_run(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name")
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 @patch("dataquality.core.init.create_run_name", return_value="foo")
 def test_init_project_name_collision(
     mock_create_run_name: MagicMock,
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -407,15 +387,13 @@ def test_init_project_name_collision(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name")
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 @patch("dataquality.core.init.create_run_name", return_value="foo")
 def test_init_project_name_collision_fails(
     mock_create_run_name: MagicMock,
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -452,15 +430,13 @@ def test_init_failed_login(mock_login: MagicMock, set_test_config: Callable) ->
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name", return_value={})
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch("dataquality.core.init.login", side_effect=mocked_login)
 @patch("dataquality.core.init.create_run_name", return_value="foo")
 def test_init_successful_login(
     mock_create_run_name: MagicMock,
     mock_login: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -498,7 +474,6 @@ def test_init_expired_token_login(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name", return_value={})
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(
     dataquality.core.init.ApiClient, "get_current_user", side_effect=GalileoException
@@ -510,7 +485,6 @@ def test_init_expired_token_login_full(
     mock_login: MagicMock,
     mock_current_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -546,7 +520,6 @@ def test_init_invalid_user_login(
 @patch.object(ApiClient, "create_project")
 @patch.object(ApiClient, "get_project_run_by_name", return_value={})
 @patch.object(ApiClient, "create_run")
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=False)
 @patch("dataquality.core.init.login", side_effect=mocked_login)
@@ -556,7 +529,6 @@ def test_init_invalid_user_login_full(
     mock_login: MagicMock,
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_create_run: MagicMock,
     mock_get_project_run_by_name: MagicMock,
     mock_create_project: MagicMock,
@@ -576,13 +548,11 @@ def test_init_invalid_user_login_full(
     assert config.current_project_id == test_session_vars.DEFAULT_PROJECT_ID
 
 
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(dataquality.core.init.ApiClient, "valid_current_user", return_value=True)
 def test_init_bad_task(
     mock_valid_user: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
 ) -> None:
     with pytest.raises(GalileoException) as e:
         dataquality.init(task_type="fake_task_type")
@@ -635,7 +605,6 @@ def test_reconfigure_resets_user_token_login_mocked(
 
 @patch("requests.post", side_effect=mocked_create_project_run)
 @patch("requests.get", side_effect=mocked_get_project_run)
-@patch("dataquality.core.init.version_check")
 @patch("dataquality.core.init._check_dq_version")
 @patch.object(
     dq.clients.api.ApiClient,
@@ -665,7 +634,6 @@ def test_bad_names(
     mock_valid_user: MagicMock,
     mock_dq_healthcheck: MagicMock,
     mock_check_dq_version: MagicMock,
-    mock_version_check: MagicMock,
     mock_requests_get: MagicMock,
     mock_requests_post: MagicMock,
     run_name: str,

diff --git a/tests/integrations/fastai/test_cv_fai.py b/tests/integrations/fastai/test_cv_fai.py
@@ -27,7 +27,6 @@
 
 
 @patch.object(ApiClient, "valid_current_user", return_value=True)
-@patch.object(dq.core.init, "version_check")
 @patch.object(dq.core.finish, "_reset_run")
 @patch.object(dq.core.finish, "upload_dq_log_file")
 @patch.object(ApiClient, "make_request")
@@ -63,7 +62,6 @@ def test_fast_ai_integration_e2e(
     mock_make_request: MagicMock,
     mock_upload_log_file: MagicMock,
     mock_reset_run: MagicMock,
-    mock_version_check: MagicMock,
     cleanup_after_use: Generator,
     test_session_vars: TestSessionVariables,
 ) -> None:
@@ -196,7 +194,6 @@ def seed_worker(worker_id: int) -> None:
 
 
 @patch.object(ApiClient, "valid_current_user", return_value=True)
-@patch.object(dq.core.init, "version_check")
 @patch.object(dq.core.finish, "_reset_run")
 @patch.object(dq.core.finish, "upload_dq_log_file")
 @patch.object(ApiClient, "make_request")
@@ -232,7 +229,6 @@ def test_tabular_dataloader(
     mock_make_request: MagicMock,
     mock_upload_log_file: MagicMock,
     mock_reset_run: MagicMock,
-    mock_version_check: MagicMock,
     cleanup_after_use: Generator,
     test_session_vars: TestSessionVariables,
 ) -> None:

diff --git a/tests/integrations/fastai/test_text_fai.py b/tests/integrations/fastai/test_text_fai.py
@@ -24,7 +24,6 @@
 
 
 @patch.object(ApiClient, "valid_current_user", return_value=True)
-@patch.object(dq.core.init, "version_check")
 @patch.object(dq.core.finish, "_reset_run")
 @patch.object(dq.core.finish, "upload_dq_log_file")
 @patch.object(ApiClient, "make_request")
@@ -60,7 +59,6 @@ def test_end2end_fai(
     mock_make_request: MagicMock,
     mock_upload_log_file: MagicMock,
     mock_reset_run: MagicMock,
-    mock_version_check: MagicMock,
     cleanup_after_use: Generator,
     test_session_vars: TestSessionVariables,
 ) -> None:

diff --git a/tests/integrations/keras/test_end2end_keras.py b/tests/integrations/keras/test_end2end_keras.py
@@ -85,7 +85,6 @@ def preprocess_function(examples, tokenizer):
 
 
 @patch.object(dq.core.init.ApiClient, "valid_current_user", return_value=True)
-@patch.object(dq.core.init, "version_check")
 @patch.object(dq.core.finish, "_reset_run")
 @patch.object(dq.core.finish, "upload_dq_log_file")
 @patch.object(dq.clients.api.ApiClient, "make_request")
@@ -95,7 +94,6 @@ def test_hf_watch_e2e_numbered(
     mock_make_request: MagicMock,
     mock_upload_log_file: MagicMock,
     mock_reset_run: MagicMock,
-    mock_version_check: MagicMock,
     mock_valid_user: MagicMock,
     set_test_config: Callable,
     cleanup_after_use: Generator,
@@ -155,7 +153,6 @@ def test_hf_watch_e2e_numbered(
 
 
 @patch.object(dq.core.init.ApiClient, "valid_current_user", return_value=True)
-@patch.object(dq.core.init, "version_check")
 @patch.object(dq.core.finish, "_reset_run")
 @patch.object(dq.core.finish, "upload_dq_log_file")
 @patch.object(dq.clients.api.ApiClient, "make_request")
@@ -165,7 +162,6 @@ def test_tf_watch_e2e_numbered(
     mock_make_request: MagicMock,
     mock_upload_log_file: MagicMock,
     mock_reset_run: MagicMock,
-    mock_version_check: MagicMock,
     mock_valid_user: MagicMock,
     set_test_config: Callable,
     cleanup_after_use: Generator,

diff --git a/tests/integrations/semantic/test_torch_semantic.py b/tests/integrations/semantic/test_torch_semantic.py
@@ -247,7 +247,6 @@ def step(self):
 optimizer = DummyOptimizer()
 
 
-@patch.object(dq.core.init, "version_check")
 @patch.object(dq.core.finish, "_reset_run")
 @patch.object(dq.core.finish, "upload_dq_log_file")
 @patch.object(ApiClient, "make_request")
@@ -284,7 +283,6 @@ def test_semantic(
     mock_make_request: MagicMock,
     mock_upload_log_file: MagicMock,
     mock_reset_run: MagicMock,
-    mock_version_check: MagicMock,
     set_test_config: Callable,
     cleanup_after_use: Generator,
     test_session_vars: TestSessionVariables,