Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bundler to 2.5.21 and truffleruby to 24.1.0 #67

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

Nothing, I saw a PR will failing CI and wondering if updating Bundler will fix it. I don't think it will, to be honest, but upgrading doesn't hurt.

What is your fix for the problem, implemented in this PR?

Upgrade Bundler.

Make sure the following tasks are checked

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/update-bundler branch 7 times, most recently from 7924f9d to 71d49b9 Compare September 30, 2024 11:02
@deivid-rodriguez deivid-rodriguez changed the title Update Bundler to 2.5.19 Update Bundler to 2.5.20 and fix CI Oct 2, 2024
@simi
Copy link
Member

simi commented Oct 9, 2024

🪟 💥 Any idea what's happening on CI?

@deivid-rodriguez
Copy link
Member Author

I thought I had fixed it, but apparently I did not. Looking into it.

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/update-bundler branch 2 times, most recently from 14b6e04 to 625d9af Compare October 9, 2024 07:02
@deivid-rodriguez deivid-rodriguez changed the title Update Bundler to 2.5.20 and fix CI Update Bundler to 2.5.21 and fix CI Oct 9, 2024
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/update-bundler branch 2 times, most recently from 3e3969f to 2258bf4 Compare October 9, 2024 09:13
@deivid-rodriguez
Copy link
Member Author

A bit of back and forth looking for the culprit since there are many moving parts for mswin, but I believe MSP-Greg/ruby-loco#15 should get our CI back on track.

@deivid-rodriguez deivid-rodriguez changed the title Update Bundler to 2.5.21 and fix CI Update Bundler to 2.5.21 and truffleruby to 24.1.0 Oct 11, 2024
@deivid-rodriguez
Copy link
Member Author

Everything is green now!

@deivid-rodriguez deivid-rodriguez merged commit 6ce7a2a into master Oct 11, 2024
16 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/update-bundler branch October 11, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants