Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4672-Header-Alignment-on-all-things #4715

Closed
wants to merge 1 commit into from
Closed

4672-Header-Alignment-on-all-things #4715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/adjustments/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@
<table class="table">
<thead>
<tr>
<th>Created</th>
<th>Organization</th>
<th class = "text-center">Created</th>
<th >Organization</th>
<th>Storage location</th>
<th>Comment</th>
<th>Summary</th>
Expand Down
6 changes: 3 additions & 3 deletions app/views/items/_item_list.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
<tr>
<th>Category</th>
<th>Name</th>
<th>Quantity Per Individual</th>
<th>Fair Market Value (per item)</th>
<th class = "text-right">Quantity Per Individual</th>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that Quantity Per Individual should be aligned right, but the information in the column isn't, so it looks weird. It'd be fine if you wanted to go into the _item_row.html.erb and make the item_row.distribution_quantity aligned right as well.

<th class = "text-right">Fair Market Value (per item)</th>
<% if Flipper.enabled?(:enable_packs) %>
<% unless current_organization.request_units.empty? %>
<th>Custom Request Units</th>
<% end %>
<% end %>
<th class="text-center">Actions</th>
<th class = "text-right">Actions</th>
</tr>
</thead>
<tbody>
Expand Down
8 changes: 4 additions & 4 deletions app/views/purchases/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@
<th>Purchases from</th>
<th>Storage Location</th>
<th>Comments</th>
<th>Quantity of Items</th>
<th>Variety of Items</th>
<th>Amount spent</th>
<th class= "text-right">Quantity of Items</th>
<th class = "text-right">Variety of Items</th>
<th class = "text-right">Amount spent</th>
<th>FMV</th>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FMV Should be aligned right

<th>Purchased Date</th>
<th class = "text-right">Purchased Date</th>
<th class="text-right">Actions</th>
</tr>
</thead>
Expand Down