4672-Header-Alignment-on-all-things #4715
Conversation
|
Hey @inane-pixel - Thank you for doing all this checking! It might take a day or two before this gets reviewed. One thing for future -- it's good practice to create a new branch when you are going to be submitting a PR to a project. |
There was a problem hiding this comment.
Hey @inane-pixel -- I made a couple of suggestions. I'm realizing that we need to update some of the numeric columns to be right-justified, but we'll handle that overall in another issue.
| <th>Amount spent</th> | ||
| <th class= "text-right">Quantity of Items</th> | ||
| <th class = "text-right">Variety of Items</th> | ||
| <th class = "text-right">Amount spent</th> | ||
| <th>FMV</th> |
There was a problem hiding this comment.
FMV Should be aligned right
| @@ -8,14 +8,14 @@ | |||
| <tr> | |||
| <th>Category</th> | |||
| <th>Name</th> | |||
| <th>Quantity Per Individual</th> | |||
| <th>Fair Market Value (per item)</th> | |||
| <th class = "text-right">Quantity Per Individual</th> | |||
There was a problem hiding this comment.
I agree that Quantity Per Individual should be aligned right, but the information in the column isn't, so it looks weird. It'd be fine if you wanted to go into the _item_row.html.erb and make the item_row.distribution_quantity aligned right as well.
|
Closing this pull request, as another has been opened in its place. |
Resolves #4672
Description
Match header alignment to the contents on all tables to make contents easier to read.
Type of change
###Edited
###Checked: