Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quotes of <main> #3384

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Fix quotes of <main> #3384

merged 1 commit into from
Oct 9, 2024

Conversation

znz
Copy link
Member

@znz znz commented Oct 8, 2024

This changed since 3.4.0-preview1.

% docker run --platform linux/amd64 --rm -it ghcr.io/ruby/all-ruby env LANG=C.UTF-8 ALL_RUBY_SINCE=ruby-3.3 ./all-ruby -e 'def foo; time; end; foo'
ruby-3.3.0          -e:1:in `foo': undefined local variable or method `time' for main (NameError)

                    def foo; time; end; foo
                             ^^^^
                        from -e:1:in `<main>'
                exit 1
...
ruby-3.3.4          -e:1:in `foo': undefined local variable or method `time' for main (NameError)

                    def foo; time; end; foo
                             ^^^^
                        from -e:1:in `<main>'
                exit 1
ruby-3.4.0-preview1 -e:1:in 'Object#foo': undefined local variable or method 'time' for main (NameError)

                    def foo; time; end; foo
                             ^^^^
                        from -e:1:in '<main>'
                exit 1

This changed since 3.4.0-preview1.

```
% docker run --platform linux/amd64 --rm -it ghcr.io/ruby/all-ruby env LANG=C.UTF-8 ALL_RUBY_SINCE=ruby-3.3 ./all-ruby -e 'def foo; time; end; foo'
ruby-3.3.0          -e:1:in `foo': undefined local variable or method `time' for main (NameError)

                    def foo; time; end; foo
                             ^^^^
                        from -e:1:in `<main>'
                exit 1
...
ruby-3.3.4          -e:1:in `foo': undefined local variable or method `time' for main (NameError)

                    def foo; time; end; foo
                             ^^^^
                        from -e:1:in `<main>'
                exit 1
ruby-3.4.0-preview1 -e:1:in 'Object#foo': undefined local variable or method 'time' for main (NameError)

                    def foo; time; end; foo
                             ^^^^
                        from -e:1:in '<main>'
                exit 1
```
@znz znz requested review from a team as code owners October 8, 2024 01:42
Copy link
Member

@JuanitoFatas JuanitoFatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@JuanitoFatas JuanitoFatas merged commit 9411a3d into ruby:master Oct 9, 2024
1 check passed
@znz znz deleted the fix-quotes branch October 9, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants