Replace deprecated usages of boost #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonegk
force-pushed
the
std-shared-ptr
branch
from
ab783ce
to
e3414c5
Compare
|
Apparently the change is not in Ubuntu focal so this has to wait until focal is EOL. |
marip8
reviewed
Apr 29, 2024
Comment on lines
-22
to
+21
| #include <boost/progress.hpp> | ||
| #include <boost/timer/progress_display.hpp> |
There was a problem hiding this comment.
I think we could probably do something like this to continue supporting focal but fix the deprecation problem
#if __has_include(<boost/timer/progress_display.hpp>)
#include <boost/timer/progress_display.hpp>
#else
#include <boost/progress.hpp>
#endifThere was a problem hiding this comment.
The namespace also changed, so the fix is not as easy, unfortunately
There was a problem hiding this comment.
I see. I was hoping we could use an alias, but it appears that timer is a class in focal, so this won't be possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost::progress_displayis deprecated and replaced byboost::timer::progress_displaystd::shared_ptrcan be used instead ofboost::shared_ptrbecause the project is using C++ >= 11