Prompt users during make() in interactive mode #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #762 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 72 72
Lines 6106 6122 +16
=====================================
+ Hits 6106 6122 +16
Continue to review full report at Codecov.
|
wlandau-lilly
added a commit
to wlandau/roweb2
that referenced
this pull request
Mar 1, 2019
stefaniebutland
pushed a commit
to ropensci-archive/roweb2
that referenced
this pull request
Mar 18, 2019
* Change the video player in the drake tech note The default PowToon player is having problems, so I propose a switch to Wistia. * Add technote: drake version 7.0.0 * Try to fix authors field * Rm mtcars beforehand Needed to consistently reproduce `lock_envir = FALSE` behavior. Also add a link. * Reknit drake tech note ropensci/drake#756 * Reknit to remove superfluous message * Add a tag * Update drake 7.0.0 tech note... ...re ropensci/drake#762 * Add more thanks * Update a header * Clean up error messages in drake itself * Minor edit * Minor elaboration * Minor update: reduced verbosity in drake * Mention some future work * Update drake tech note re ropensci/drake#765 * Clean up the section on interactive sessions * Fix a typo * Fix a link * Edit recap section in drake tech note * Sync recap * Mention @tjmahr Ref: ropensci/drake#775 * Last-minute edits to the drake v7 tech note * Update word choice * Knit in batch mode * Mention literate programming * Address https://github.com/ropensci/roweb2/pull/423/files#r264418051 * Address https://github.com/ropensci/roweb2/pull/423/files#r264418238 * Add a mention Reduced trigger verbosity suggested by @aedobbyn: ropensci/drake@ec050a4 * Alphabetize mentions by first name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
drakegets initial dependencies from the user's environment rather than script files. However, environments are brittle, so targets can falsely invalidate if you runmake()in a stale R session. This PR implements safeguards and reminders formake()in interactive mode. If the R session is interactive and some targets are out of date,make()prompts you with a menu to keep you from accidentally mangling your project. It also reminds you to read #761 regardless of how your targets are doing.You can disable the menu with
make(force = TRUE)oroptions(drake_force_interactive = TRUE).cc @MilesMcBain, @ha0ye
Related GitHub issues and pull requests
Checklist
drake's code of conduct, and I agree to follow its rules.testthatunit tests totests/testthatto confirm that any new features or functionality work correctly.devtools::check()