Roam-Toolkit Safari web extension for Safari 12+ #44 #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Nice, thank you! Will take a closer look on Sat!
That sounds like something that can be used. Will double check exact functionality and see if those are required! |
|
I would love if roam-toolkit supported Safari out-of-the-box. Safari provides an unparalleled experience in macOS compared to Firefox and Chrome. Let me know if I can help out review this PR or get it through the finish line. |
|
did upload a version that works with roam/js in #164 fyi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion is trivial with Xcode 12 and Safari 14 installed. See these docs
The persistent and clipboardRead keys in manifest.json on HEAD are not supported by Safari, but those don't seem necessary for Roam-Toolkit to function.
The extension is bundled inside a macOS app. A user installs the extension by opening the app. @Stvad you can release the extension via the Mac App Store or in a dmg/zip after signing with a Developer ID Application certificate. An Developer account is not required to use the extension: run the Xcode project and follow these steps for Safari to allow the unsigned extension.
After conversion, I modified the access permissions to only access roamresearch.com
It's pretty seamless. I'm not a heavy user of Roam Toolkit, but it seems that everything in the Chrome extension works on Safari.