Two small fixes #310
Merged
Two small fixes #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the archive start offset can never be negative. Fixes a case found by OSSFuzz.
It makes sense to avoid changing the offset and/or the archive size when the user specifies a buffer rather than a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes a silly oversight in the freshly-added code, the fuzzer found the problem in no time.
The second commit is slightly different as it prevents the user error to some degree, the
mz_zip_mem_read_funcfunction doesn't use them_file_archive_start_ofsfield and am not sure if it should. So this commit prevents the new machinery from changing the offset/size of the archive, if you feel the problem should be solved in another way (e.g. takingm_file_archive_start_ofsinto account) I'll amend the PR asap.