Replace taskGraph.afterTask with an operation completion listener in Gradle 6.1+

[Vampire]

No description provided.

[yorlov]

Just to let you know, the plugin will not function on gradle 8.7 until this issue is rectified.

FAILURE: Build failed with an exception.

* What went wrong:
Configuration cache problems found in this build.

1 problem was found storing the configuration cache.
- Plugin 'net.researchgate.release': registration of listener on 'TaskExecutionGraph.afterTask' is unsupported
  See https://docs.gradle.org/8.6/userguide/configuration_cache.html#config_cache:requirements:build_listeners

[Vampire]

You mean the plugin will not function with 8.x if you enable configuration cache, which is not different in 8.7 from earlier versions.

[Hillkorn]

Suggested change

	if (scmAdapter && extension.revertOnFail && project.file(extension.versionPropertyFile)?.exists()) {
	if (scmAdapter && extension.revertOnFail.get() && project.file(extension.versionPropertyFile)?.exists()) {

Not sure what groovy does if we don't use the get() .

[Vampire]

The same it does currently, I just moved this existing code to a method.
But you are fully right of course, for Groovy it will just always be true as it is non-null.
This is already like that since switching to properties and not adapting this usage (and maybe others?)
One of the fun things you have because of using Groovy for the plugin. :-D

I now fixed it together with this PR.

[Hillkorn]

What is the reason for this change?
I see that you added

    @Inject
    abstract protected ObjectFactory getObjects();

    @Inject
    abstract protected ProviderFactory getProviders();

But I don't get the why.

[Vampire]

Because I use them at

gradle-release/src/main/groovy/net/researchgate/release/ReleasePlugin.groovy

Line 174 in 7ffe081

objects.newInstance(BuildEventsListenerRegistryProvider)

and

gradle-release/src/main/groovy/net/researchgate/release/ReleasePlugin.groovy

Line 176 in 7ffe081

.onTaskCompletion(providers.provider {

Of course you can get those from project too, but that is bad / outdated practice and I didn't want to add to the existing ones but doing it right. :-)

[Hillkorn]

Ah I see. Thanks for the explanation 👍