Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicts with X11 headers by adding #undef Unsorted #7855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 21, 2024

Some C library uses macros for constants, which makes those identifiers unusable by any other library in the same global namespace. So anyone including both X.h and rerun.hpp in the same compilation unit (in that order) would have problems. It's a dumpster-fire.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🪳 bug Something isn't working 🌊 C++ API C/C++ API specific include in changelog labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🌊 C++ API C/C++ API specific include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enum SortingStatus::Unsorted conflicts with define in X.h
1 participant