chore: add missing deps to Pipfile and fix a typo #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tumido
force-pushed
the
getting-familiar-with-standalone
branch
8 times, most recently
from
65f441d
to
c839ce7
Compare
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
tumido
force-pushed
the
getting-familiar-with-standalone
branch
from
c839ce7
to
5bfb005
Compare
tumido
changed the title
|
Trying to see if we can sync GH action with Pipenv dev environment. Bear with me. 😄 |
tumido
changed the title
leseb
reviewed
Oct 14, 2024
tumido
force-pushed
the
getting-familiar-with-standalone
branch
from
713be2f
to
22c176c
Compare
|
I think you need to ruff the imports. |
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
tumido
force-pushed
the
getting-familiar-with-standalone
branch
from
22c176c
to
641f0e2
Compare
leseb
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA
I'm getting familiar myself with the
standalone/*codebase. This is a housekeeping PR to fix up things I've noticed to be out of order.