Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove training PVC from SDG Job #79

Closed
wants to merge 1 commit into from
Closed

Remove training PVC from SDG Job #79

wants to merge 1 commit into from

Conversation

astefanutti
Copy link
Collaborator

This removes the training PVC from the SDG Job as it's not needed, and simplifies testing the SDG data download from S3 on cluster that does not support the provisioning of ReadWriteMany PVC.

leseb
leseb requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the RWX PVC on that pod to copy the model into it.

@astefanutti
Copy link
Collaborator Author

We need the RWX PVC on that pod to copy the model into it.

Isn't that the PVC referred by MODEL_PVC_NAME? My (limited) understanding is that it's different from the one referred by TRAINING_PVC_NAME.

@leseb
Copy link
Collaborator

leseb commented Oct 9, 2024

We need the RWX PVC on that pod to copy the model into it.

Isn't that the PVC referred by MODEL_PVC_NAME? My (limited) understanding is that it's different from the one referred by TRAINING_PVC_NAME.

Sorry for the confusion, these are old relics of artifacts coming from the "sdg" mode (now hidden) of the script. This commit fixes that 42bcfb4.

@astefanutti
Copy link
Collaborator Author

Sorry for the confusion, these are old relics of artifacts coming from the "sdg" mode (now hidden) of the script. This commit fixes that 42bcfb4.

Ah great, I missed it. Closing this in favor of #76 then. Sorry for the noise. Thanks.

@astefanutti astefanutti closed this Oct 9, 2024
@leseb
Copy link
Collaborator

leseb commented Oct 9, 2024

Sorry for the confusion, these are old relics of artifacts coming from the "sdg" mode (now hidden) of the script. This commit fixes that 42bcfb4.

Ah great, I missed it. Closing this in favor of #76 then. Sorry for the noise. Thanks.

No worries, happy to see contribution and interest!

@astefanutti astefanutti deleted the pr-02 branch October 9, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leseb leseb leseb requested changes

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astefanutti @leseb