small clean up for mt_bench #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Clifford <mcliffor@redhat.com>
Signed-off-by: Michael Clifford <mcliffor@redhat.com>
MichaelClifford
force-pushed
the
fix-115
branch
from
4b86418
to
d7833d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115 and #114
This PR prevents
run_mt_bench_op()from attempting to load any*.jsonlfiles as a model. It also checks for the existence of acandidate_model/directory before trying to create one.Both of these issues can occur if the PVC is not properly cleaned between runs and can cause unexpected errors.