Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(RHTAPWATCH-672): add tests for compose_generator #8

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

yftacherzog
Copy link
Member

@yftacherzog yftacherzog commented Dec 11, 2023

Test ComposeGenerator class using mock dependencies

@yftacherzog yftacherzog changed the title test: add tests for compose_generator test(RHTAPWATCH-672): add tests for compose_generator Dec 11, 2023
@yftacherzog
Copy link
Member Author

@Omeramsc please take a look

Copy link
Member

@Omeramsc Omeramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment,
but please add an informative commit message for the commit log.

# @pytest.fixture()
# def mock_compose_generator(self) -> MagicMock:
# """Generic ComposeGenerator"""
# return create_autospec(ComposeGenerator, instance=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover comments?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@yftacherzog yftacherzog force-pushed the gen_compose-tests branch 2 times, most recently from cd4583d to 5f6e856 Compare December 11, 2023 15:47
Test ComposeGenerator class using mock dependencies

Signed-off-by: Yftach Herzog <yherzog@redhat.com>
@yftacherzog yftacherzog merged commit 9853aed into redhat-appstudio:main Dec 11, 2023
1 check passed
@yftacherzog yftacherzog deleted the gen_compose-tests branch December 11, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants