Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fetch and store ODCS compose #4

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: fetch and store ODCS compose #4

merged 1 commit into from
Dec 11, 2023

Conversation

Omeramsc
Copy link
Member

@Omeramsc Omeramsc commented Dec 6, 2023

Adds a method to pull and store ODCS compose.

@yftacherzog
Copy link
Member

@Omeramsc we still don't have a PR merged for CI, but I think we can assume tests can be added under tests dir at the root of the repo.

@Omeramsc Omeramsc marked this pull request as ready for review December 7, 2023 15:37
yftacherzog
yftacherzog reviewed Dec 10, 2023
View reviewed changes
Pipfile Outdated Show resolved Hide resolved
yftacherzog
yftacherzog reviewed Dec 10, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
yftacherzog
yftacherzog reviewed Dec 10, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@Omeramsc Omeramsc force-pushed the odcs_fetcher branch 2 times, most recently from 6f94b29 to 3ceebbf Compare December 10, 2023 09:50
@Omeramsc Omeramsc force-pushed the odcs_fetcher branch 3 times, most recently from d24619b to a9fd479 Compare December 11, 2023 11:16
@yftacherzog
Copy link
Member

See the comments I left now. Other than that, I think we're good.

@Omeramsc
chore: fetch and store ODCS compose
7b6bd83 
Adds a method to pull and store ODCS compose.

Signed-off-by: Omer <oamsalem@redhat.com>
yftacherzog
yftacherzog approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yftacherzog yftacherzog merged commit 41cf8e0 into redhat-appstudio:main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yftacherzog yftacherzog yftacherzog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Omeramsc @yftacherzog