Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test pylint with pylint-pytest plugin #27

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

Omeramsc
Copy link
Member

Adds the pylint-pytest pylint plugin to help
differentiate between code-relevant and test-relevant issues when running pylint on test files.

more info available on pypi: https://pypi.org/project/pylint-pytest/

@Omeramsc Omeramsc self-assigned this Dec 19, 2023
@yftacherzog
Copy link
Member

@Omeramsc when running in CI, does it solve the issue you raised yesterday?

@Omeramsc
Copy link
Member Author

@Omeramsc when running in CI, does it solve the issue you raised yesterday?

The plugin is from pylint's side, so I modified the static test accordingly, it is not a problem.
It is not a perfect plugin (it doesn't cover all issues, e.g docstrings), but it is an improvment over what we currently have.

@yftacherzog
Copy link
Member

@Omeramsc when running in CI, does it solve the issue you raised yesterday?

The plugin is from pylint's side, so I modified the static test accordingly, it is not a problem. It is not a perfect plugin (it doesn't cover all issues, e.g docstrings), but it is an improvment over what we currently have.

My question is whether you confirmed that the change you did is addressing the issue you raised.

@Omeramsc
Copy link
Member Author

@Omeramsc when running in CI, does it solve the issue you raised yesterday?

The plugin is from pylint's side, so I modified the static test accordingly, it is not a problem. It is not a perfect plugin (it doesn't cover all issues, e.g docstrings), but it is an improvment over what we currently have.

My question is whether you confirmed that the change you did is addressing the issue you raised.

I raised multiple issues; The one in the previous PR was solved by changing the code, so it doesn't need to solve it. This plugin doesn't support the issue raised anyway, but it does many others we may or already faced.
as for the "running in CI issue" (I also mentioned yesterday), yes, it is solved by this.

Adds the pylint-pytest pylint plugin to help
differentiate between code-relevant and test-relevant
issues when running pylint on test files.

more info available on pypi: https://pypi.org/project/pylint-pytest/

Signed-off-by: Omer <oamsalem@redhat.com>
@ifireball ifireball merged commit 41c6df1 into redhat-appstudio:main Dec 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants