Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename LOGLEVEL to LOG_LEVEL #82

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix: rename LOGLEVEL to LOG_LEVEL #82

merged 2 commits into from
Oct 15, 2024

Conversation

liuhuo23
Copy link
Contributor

@liuhuo23 liuhuo23 commented Oct 8, 2024

I found that when I used debug! to print logs, it always had no output. Eventually, I discovered that in the .envrc file it was LOG_LEVEL while in the code it was LOGLEVEL.

@orhun
Copy link
Member

orhun commented Oct 8, 2024

I would prefer the other way around and use LOG_LEVEL and update the code accordingly. I think it is more conventional, what do you think?

@liuhuo23
Copy link
Contributor Author

yes, should use LOG_LEVEL

@orhun
Copy link
Member

orhun commented Oct 14, 2024

want to make the change in the PR? 🙂

@liuhuo23
Copy link
Contributor Author

LOGLEVEL changed LOG_LEVEL.😀

@orhun
Copy link
Member

orhun commented Oct 15, 2024

Thanks!

@orhun orhun changed the title fix: update template .envrc LOG_LEVEL to LOGLEVEL fix: rename LOGLEVEL to LOG_LEVEL Oct 15, 2024
@orhun orhun merged commit 17258a5 into ratatui:main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants