[v0.10] Skip checks on logs in sharding end-to-end tests #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Skip checks on logs in sharding tests This prevents test failures when: * tests are run more than once, without logs being cleared (eg. without deployments being scaled down and back up) between runs * debug logs are disabled * Add shard ID checks on bundle and bundle deployment Sharding end-to-end tests now check that Fleet resources created from a `GitRepo` bear the same shard ID value, through the `fleet.cattle.io/shard-ref` label, as specified in the `GitRepo` itself. User resources contained in bundle deployments are not labelled with the shard ID. * Fix check on configmap absence When checking for a config map not being created, we must check that it _consistently_ doesn't exist, instead of verifying that it eventually (at a unique point in time) doesn't exist.
This was referenced Sep 11, 2024
manno
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents test failures when tests are run more than once, without logs being cleared (eg. without deployments being scaled down and back up) between runs, or when debug logs are disabled
Sharding end-to-end tests now check that Fleet resources created from a
GitRepobear the same shard ID value, through thefleet.cattle.io/shard-reflabel, as specified in theGitRepoitself.User resources contained in bundle deployments are not labelled with the shard ID.
When checking for a config map not being created, we must check that it consistently doesn't exist, instead of verifying that it eventually (at a unique point in time) doesn't exist.
Backport of #2832 to v0.10.
Refers to #2828.