Fixed: KeyError caused due to the same element getting removed from a set twice

[anmol-aidora]

for item_a in set_a:
    for item_b in set_b:
        if <some condition:True>:
            set_a.remove(item_a)

As you can see, if there are multiple items in set_b for which the condition evaluates to True, set_a.remove(item_a) will run twice, which will cause KeyError for second time onwards.

To solve this problem, I am checking whether the item_a is there in the set_a before removing. If it is, then remove, if it isn't then continue without removing as we have already removed it

[stefan6419846]

There should probably be a test as well which covers this case. Additionally, using uncommon_items.discard(item_a) directly should do the same with less code.

[anmol-aidora]

There should probably be a test as well which covers this case. Additionally, using uncommon_items.discard(item_a) directly should do the same with less code.

Thanks @stefan6419846 for pointing out this method. For the uninitiated:
The discard() method removes the specified item from the set. This method is different from the remove() method, because the remove() method will raise an error if the specified item does not exist, and the discard() method will not.

I am not sure how to write a test case for this. I will take that up later