Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger as dependency to address warnings against Ruby 3.4.0dev #813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Oct 22, 2024

  1. Add logger as dependency to address warnings against Ruby 3.4.0dev

    This commit addresses the `warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.`
    against Ruby 3.4.0dev
    
    * Steps to reproduce
    
    ```ruby
    $ ruby -v
    ruby 3.4.0dev (2024-10-21T16:48:53Z master 5131fb5dbe) +PRISM [x86_64-linux]
    $ bundle exec rake 2>&1 |grep 'warning: logger'
    ```
    
    * Warnings addressed by this commit:
    
    ```
    /path/to/sprockets/lib/sprockets/base.rb:4: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
    /path/to/sprockets/lib/sprockets/cache/file_store.rb:3: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
    /path/to/sprockets/lib/sprockets/cache.rb:2: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
    /path/to/sprockets/lib/sprockets/manifest_utils.rb:3: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
    /path/to/sprockets/lib/sprockets.rb:5: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
    ```
    
    * Refer to the following URL for the background of this change:
    https://bugs.ruby-lang.org/issues/20309
    ruby/ruby@d7e558e
    yahonda committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e87e7c6 View commit details
    Browse the repository at this point in the history