Reply to All RoomMessageEvents #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitsuneRal
reviewed
Sep 25, 2024
KitsuneRal
previously approved these changes
Sep 30, 2024
My plan was to do that as a follow up |
…s any message can now be replied to.
nvrWhere
force-pushed
the
nvrwhere/reply_all
branch
from
086a45b
to
fee5b8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v1.3 of the spec any RoomMessageEvent can be used to reply to another. This moves the EventRelation out of text content and makes it a part of RoomMessageEvent itself.
This is part 1 which is just reworking the API in RoomMessageEvent, there will be further follow up to hook it up so that you can add an EventRelation to all the helpers for sending RoomMessageEvents in Room.
This also fixes a couple of cock ups in the dump to functions from my last commit.