Bugfix sort order query string in elastic search api. #5490
+68
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
sort-order-query-string-broken
branch
3 times, most recently
from
b9a030f
to
ce8fcaf
Compare
The sort order was parsed using the generated from_str_name method. The spec of this method probably changed at one point, and we ended up requiring sort order to be uppercase. This PR changes the behavior to follow what we do when we parse a json string, and adds unit tests. Closes #5491
fulmicoton
force-pushed
the
sort-order-query-string-broken
branch
from
ce8fcaf
to
d95318c
Compare
trinity-1686a
approved these changes
Oct 15, 2024
|
fix #5491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.