Issue/5474 merge pipeline finalization #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
issue/5474-merge-pipeline-finalization
branch
13 times, most recently
from
4c16e96
to
1bed4b1
Compare
fulmicoton
force-pushed
the
issue/5474-merge-pipeline-finalization
branch
7 times, most recently
from
9a50f0f
to
2dd11bd
Compare
fulmicoton
force-pushed
the
issue/5474-merge-pipeline-finalization
branch
from
2dd11bd
to
ff62bc5
Compare
Before this PR, when the last indexing pipeline is shutdown, the merge pipeline associated to an index would be abruptly shutdown too. This PR makes two changes to this behavior. First, we wait for ongoing or pending merges to be executed before shutting down the pipeline. Second, merge policy get the opportunity to offer a list of extra merges to run. This functionality is introduced to help users who migrated from elasticsearch and rely on a daily indexes. Closes #5474
fulmicoton
force-pushed
the
issue/5474-merge-pipeline-finalization
branch
from
ff62bc5
to
d0ce172
Compare
guilload
approved these changes
Oct 9, 2024
Co-authored-by: Adrien Guillo <adrien@quickwit.io>
fulmicoton
force-pushed
the
issue/5474-merge-pipeline-finalization
branch
from
3c67952
to
7966e7e
Compare
fulmicoton
force-pushed
the
issue/5474-merge-pipeline-finalization
branch
from
7966e7e
to
129f93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, when the last indexing pipeline
is shutdown, the merge pipeline associated to an index
would be abruptly shutdown too.
This PR makes two changes to this behavior.
First, we wait for ongoing or pending merges to
be executed before shutting down the pipeline.
Second, merge policy get the opportunity to offer
a list of extra merges to run.
This functionality is introduced to help users
who migrated from elasticsearch and rely on a daily
indexes.
Closes #5474