Variable for exploit distance check #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many complain about false bans. Just increase this number a little.
nick-perry14
suggested changes
Jul 26, 2024
| @@ -7,6 +7,7 @@ local FingerDrops = {} | |||
| local Objects = {} | |||
| local QBCore = exports['qb-core']:GetCoreObject() | |||
| local updatingCops = false | |||
| local exploit_distance_check = 2.5 -- If you are getting exploit bans, increase this number | |||
There was a problem hiding this comment.
This should be as a config variable. If you want it user-editable, please place it there.
| @@ -711,7 +712,7 @@ RegisterNetEvent('police:server:TakeOutImpound', function(plate, garage) | |||
| local playerPed = GetPlayerPed(src) | |||
| local playerCoords = GetEntityCoords(playerPed) | |||
| local targetCoords = Config.Locations['impound'][garage] | |||
| if #(playerCoords - targetCoords) > 10.0 then return DropPlayer(src, 'Attempted exploit abuse') end | |||
| if #(playerCoords - targetCoords) > exploit_distance_check * 4 then return DropPlayer(src, 'Attempted exploit abuse') end | |||
There was a problem hiding this comment.
Magic Number here - I understand why it's *4 but in this case, it would probably be better to just make a separate "impound_exploit_distance_check". Because 10 may be enough but the 2.5 for other things may not.
|
This PR has had 60 days of inactivity & will close within 7 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many complain about false bans. Just increase this number a little.
Describe Pull request
First, make sure you've read and are following the contribution guidelines and style guide and your code reflects that.
Write up a clear and concise description of what your pull request adds or fixes and if it's an added feature explain why you think it should be included in the core.
If your PR is to fix an issue mention that issue here
Questions (please complete the following information):