Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds use of GCPDefinition instead of SwathDefinition to Modis L1b reader #2283

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BENR0
Copy link
Collaborator

@BENR0 BENR0 commented Nov 17, 2022

These changes introduce the use of GCPDefinition (SwathDefinition with ground control points pytroll/pyresample#476) for the Modis L1b reader.

This should be used as a base for discussion of how/where SwathDefinitions/ GCPDefinitions should be created reader/FileYAMLReader. Currently if get_area_def is not implemented in the reader a SwathDefinition is created in the FileYAMLReader as a "fallback" in a kind of way.

Possible Questions:

  • change get_area_def to get_area in the reader to make it clearer that this should be used for creation of AreaDefinitions as well as SwathDefinitions (with control points).
  • refactor the logic of FileYAMLReader and readers how to create SwathDefinitions with ground control points and interpolation?
    • e.g. should it be necessary to include tiepoints as a variable and add it to the coordinates keyword for the other datasets in the yaml file of the reader (as is done here)? Alternatively introduction of a "depends_on"/"requires" keyword which can be used to indicate that full lat/lons depend on tiepoints?

...

  • Tests added
  • Fully documented

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #2283 (71afcda) into main (f9c2070) will decrease coverage by 0.04%.
The diff coverage is 13.04%.

@@            Coverage Diff             @@
##             main    #2283      +/-   ##
==========================================
- Coverage   94.32%   94.28%   -0.05%     
==========================================
  Files         308      308              
  Lines       46168    46191      +23     
==========================================
+ Hits        43546    43549       +3     
- Misses       2622     2642      +20     
Flag Coverage Δ
behaviourtests 4.61% <4.34%> (-0.01%) ⬇️
unittests 94.91% <13.04%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/yaml_reader.py 95.36% <9.52%> (-2.15%) ⬇️
satpy/readers/hdfeos_base.py 91.93% <50.00%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 94.867% when pulling 71afcda on BENR0:feature_tiepoints_def_modis into f9c2070 on pytroll:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants