Add a test for runing from start to finish #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
===========================================
+ Coverage 38.85% 55.71% +16.85%
===========================================
Files 15 15
Lines 2082 2100 +18
===========================================
+ Hits 809 1170 +361
+ Misses 1273 930 -343 ☔ View full report in Codecov by Sentry. |
adybbroe
reviewed
Apr 9, 2024
| @@ -96,7 +95,7 @@ def single_station(self, sched, start_time, tle_file): | |||
|
|
|||
| allpasses = self.get_next_passes(opts, sched, start_time, tle_file) | |||
|
|
|||
| area_boundary = AreaDefBoundary(self.area, frequency=500) | |||
| area_boundary = self.area.boundary(8) | |||
There was a problem hiding this comment.
Do we have a test for this?
There was a problem hiding this comment.
well, I changed this because of a deprecation warning from pyresample, and the test I wrote (that check that generating a schedule works) passes, which wouldn't if this call was wrong...
adybbroe
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes many small things that were outdated.