Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix higher_order contiguity including lower order #739

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

martinfleis
Copy link
Member

Fixes #738

Funnily enough, we have the same line of code in weights/raster.py, where it is correct.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.2%. Comparing base (e82d1be) to head (94ff95e).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #739     +/-   ##
=======================================
+ Coverage   83.9%   85.2%   +1.3%     
=======================================
  Files        145     145             
  Lines      15583   15642     +59     
=======================================
+ Hits       13077   13326    +249     
+ Misses      2506    2316    -190     
Files Coverage Δ
libpysal/graph/base.py 96.8% <100.0%> (ø)
libpysal/graph/tests/test_base.py 100.0% <100.0%> (ø)
libpysal/weights/util.py 78.0% <100.0%> (ø)

... and 9 files with indirect coverage changes

@martinfleis martinfleis self-assigned this Jul 6, 2024
@martinfleis martinfleis added the bug functionality that: returns invalid, erroneous, or meaningless results; or doesn't work at all. label Jul 6, 2024
@martinfleis
Copy link
Member Author

(the dev failure is coming from incompatibility between pandas main and geopandas, nothing to solve here)

@martinfleis martinfleis merged commit d471e76 into pysal:main Jul 16, 2024
11 checks passed
@martinfleis martinfleis deleted the higher-order-fix branch July 16, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug functionality that: returns invalid, erroneous, or meaningless results; or doesn't work at all.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: higher_order(lower_order=True) not working in edge cases
2 participants