Potential fix for incorrect reading of data with empty cells when used with pyexcel #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for your PR! could you please write unit tests for your code change? |
Codecov Report
@@ Coverage Diff @@
## dev #9 +/- ##
==========================================
- Coverage 97.52% 97.37% -0.15%
==========================================
Files 11 11
Lines 444 457 +13
==========================================
+ Hits 433 445 +12
- Misses 11 12 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
wtf its still not fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into the same problem as reported on issue #8 today and implemented a workaround.
It's a somewhat rushed fix so may need some refactoring (which I will do if I have some further free time), but I'm opening the PR in case you find it useful.