test fix for blank (len 1) TXT records breaking next read

purplepixie · May 27, 2024 · 18cd3a4 · 18cd3a4
1 parent 882b742
commit 18cd3a4
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/PurplePixie/PhpDns/DNSQuery.php b/src/PurplePixie/PhpDns/DNSQuery.php
@@ -309,11 +309,16 @@ private function readRecord(): array
 
             case DNSTypes::ID_TXT:
             case DNSTypes::ID_SPF:
+                $data="";
                 for ($string_count = 0; strlen($data) + (1 + $string_count) < $ans_header['length']; $string_count++) {
                     $string_length = ord($this->readResponse(1));
                     $data .= $this->readResponse($string_length);
                 }
 
+                // test for TXT fix - skips the responsecounter ahead one in the event of a blank (len 1) TXT record
+                if ($ans_header['length']==1)
+                    $this->responsecounter++;
+
                 $string = $domain . ' TEXT "' . $data . '" (in ' . $string_count . ' strings)';
                 break;