Add initial Israel sources #476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second one passes locally with the following change and #477: |
|
Will try your configuration but it seems that Transitland was last updated 5 months ago, not so up-to-date. |
yotamN
force-pushed
the
feature/israel
branch
2 times, most recently
from
f9b32b5
to
7d9146a
Compare
yotamN
force-pushed
the
feature/israel
branch
from
7d9146a
to
2c20e0a
Compare
|
Still not sure why Israel-MOT is closing the connection so I skipped it for now |
mlundblad
reviewed
Sep 7, 2024
| "url": "https://gtfs.mot.gov.il/gtfsfiles/israel-public-transportation.zip", | ||
| "http-options": { | ||
| "headers": { | ||
| "user-agent": "Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0" |
There was a problem hiding this comment.
Although the HTTP RFCs state that the header field names should be case-insensitive, is this always true in practice? I think I've mostly seen "User-Agent" being used.
Maybe it could be worth trying to changing to that?
There was a problem hiding this comment.
We might need to make https://github.com/public-transport/transitous/blob/main/src/fetch.py#L60 case-insensitive as well then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've sent a message to Busofash regarding their error in the GTFS file.