Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort of data-/objectproperty assertion axioms #1235

Conversation

mmopitz
Copy link
Contributor

@mmopitz mmopitz commented Sep 30, 2024

refs #605

Note: This is my first contribution to protege. So I expect some rough edges ;-) .

I tried to address the sorting of data-/object-propertyAssertion in the individual views.

Analogous to the sorting of classAssertionAxioms the assertions are sorted in following order

  1. inferred/not inferred
  2. the 'displayName' of the property (using the owlObjectComparator)
  3. the 'displayName' of the object (using the owlObjectComparator)

I added the sorting to following Sections:

  1. dataPropertyAssertionAxioms
  2. objectPropertyAssertionAxioms
  3. negativeDataPropertyAssertionAxioms
  4. negativeObjectPropertyAssertionAxioms

For personal reasons I would love to see this change in the next protege release. Please let me know if further adjustments are required.

@gouttegd gouttegd added the Type: Enhancement A request for a change that is an enhancement label Oct 3, 2024
@gouttegd
Copy link
Collaborator

gouttegd commented Oct 3, 2024

Thanks for the PR. Cursorily, it looks good to me. :) I’ll have a closer look in the following days.

Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn’t find any rough edges here. :)

@gouttegd gouttegd merged commit 80c2ad7 into protegeproject:master Oct 6, 2024
3 checks passed
@mmopitz
Copy link
Contributor Author

mmopitz commented Oct 21, 2024

Thanks for merging. This will really help me in my daily work :-)

@mmopitz mmopitz deleted the feature/605-sort-data-and-object-property-assertions branch October 21, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement A request for a change that is an enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants